Compare commits

..

7 Commits

Author SHA1 Message Date
Jürgen Mummert 2bd9f6849c Use Tom Select defaults for event filter 2026-02-23 20:23:23 +01:00
Jürgen Mummert 0e0a888fa9 Replace SlimSelect with Tom Select in event filter 2026-02-23 20:16:40 +01:00
Jürgen Mummert 5d3905632d Fix SlimSelect dropdown scrolling regression 2026-02-23 20:03:08 +01:00
Jürgen Mummert fce467fa87 Harden SlimSelect scroll lock on macOS browsers 2026-02-23 20:00:36 +01:00
Jürgen Mummert f08406ec12 Fix SlimSelect scroll chaining in sticky event filter 2026-02-23 19:57:54 +01:00
Jürgen Mummert f3d4c857e0 Harden organization listing tag enrichment and simplify listener 2026-02-22 17:53:17 +01:00
Jürgen Mummert ff608f7833 Fix organization listing numeric tag rendering and template mapping 2026-02-22 17:41:36 +01:00
2 changed files with 104 additions and 291 deletions
@@ -68,12 +68,12 @@
pointer-events: none; pointer-events: none;
} }
#eventfilters .widget-select.active .ss-main { #eventfilters .widget-select.active .ts-control {
outline: 2px solid currentColor; outline: 2px solid currentColor;
outline-offset: 2px; outline-offset: 2px;
} }
#eventfilters .ss-main:focus-visible { #eventfilters .ts-control:focus-within {
outline: 2px solid currentColor; outline: 2px solid currentColor;
outline-offset: 2px; outline-offset: 2px;
} }
@@ -81,10 +81,11 @@
#eventfilters .eventfilter-reset[hidden] { #eventfilters .eventfilter-reset[hidden] {
display: none; display: none;
} }
</style> </style>
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/slim-select@3/dist/slimselect.css"> <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/tom-select@2.4.3/dist/css/tom-select.css">
<script src="https://cdn.jsdelivr.net/npm/slim-select@3/dist/slimselect.min.js"></script> <script src="https://cdn.jsdelivr.net/npm/tom-select@2.4.3/dist/js/tom-select.complete.min.js"></script>
<script type="module"> <script type="module">
const filters = document.getElementById('eventfilters'); const filters = document.getElementById('eventfilters');
@@ -117,25 +118,19 @@
let currentFilter = { type: 'all', value: 'all' }; let currentFilter = { type: 'all', value: 'all' };
let suppressedChangeEvents = 0; let suppressedChangeEvents = 0;
const initSlimSelect = (selectElement) => { const initTomSelect = (selectElement) => {
if (!selectElement || 'undefined' === typeof window.SlimSelect) { if (!selectElement || 'undefined' === typeof window.TomSelect) {
return null; return null;
} }
return new window.SlimSelect({ return new window.TomSelect(selectElement);
select: selectElement,
settings: {
showSearch: false,
allowDeselect: false,
},
});
}; };
const tagSlim = initSlimSelect(tagSelect); const tagTom = initTomSelect(tagSelect);
const locationSlim = initSlimSelect(locationSelect); const locationTom = initTomSelect(locationSelect);
const orgSlim = initSlimSelect(orgSelect); const orgTom = initTomSelect(orgSelect);
const setSelectValue = (selectElement, slimInstance, value) => { const setSelectValue = (selectElement, tomInstance, value) => {
if (!selectElement) { if (!selectElement) {
return; return;
} }
@@ -147,8 +142,8 @@
suppressedChangeEvents += 1; suppressedChangeEvents += 1;
try { try {
if (slimInstance) { if (tomInstance) {
slimInstance.setSelected(value); tomInstance.setValue(value, true);
} else { } else {
selectElement.value = value; selectElement.value = value;
} }
@@ -280,8 +275,8 @@
const selectedValue = tagSelect.value; const selectedValue = tagSelect.value;
setSelectValue(locationSelect, locationSlim, 'all'); setSelectValue(locationSelect, locationTom, 'all');
setSelectValue(orgSelect, orgSlim, 'all'); setSelectValue(orgSelect, orgTom, 'all');
applyFilter( applyFilter(
selectedValue === 'all' selectedValue === 'all'
@@ -297,8 +292,8 @@
const selectedValue = locationSelect.value; const selectedValue = locationSelect.value;
setSelectValue(tagSelect, tagSlim, 'all'); setSelectValue(tagSelect, tagTom, 'all');
setSelectValue(orgSelect, orgSlim, 'all'); setSelectValue(orgSelect, orgTom, 'all');
applyFilter( applyFilter(
selectedValue === 'all' selectedValue === 'all'
@@ -314,8 +309,8 @@
const selectedValue = orgSelect.value; const selectedValue = orgSelect.value;
setSelectValue(tagSelect, tagSlim, 'all'); setSelectValue(tagSelect, tagTom, 'all');
setSelectValue(locationSelect, locationSlim, 'all'); setSelectValue(locationSelect, locationTom, 'all');
applyFilter( applyFilter(
selectedValue === 'all' selectedValue === 'all'
@@ -325,9 +320,9 @@
}); });
resetButton?.addEventListener('click', () => { resetButton?.addEventListener('click', () => {
setSelectValue(tagSelect, tagSlim, 'all'); setSelectValue(tagSelect, tagTom, 'all');
setSelectValue(locationSelect, locationSlim, 'all'); setSelectValue(locationSelect, locationTom, 'all');
setSelectValue(orgSelect, orgSlim, 'all'); setSelectValue(orgSelect, orgTom, 'all');
applyFilter({ type: 'all', value: 'all' }); applyFilter({ type: 'all', value: 'all' });
}); });
@@ -34,11 +34,6 @@ class OrganizationListingTemplateDataListener
} }
$rowToOrganizationIdMap = []; $rowToOrganizationIdMap = [];
$rowToTitleMap = [];
$resolvedByRowIdCount = 0;
$resolvedByTitleToIdCount = 0;
$enrichedByTitleTagFallbackCount = 0;
foreach ($tbody as $rowIndex => $row) { foreach ($tbody as $rowIndex => $row) {
if (!\is_array($row)) { if (!\is_array($row)) {
@@ -49,31 +44,6 @@ class OrganizationListingTemplateDataListener
if ($organizationId > 0) { if ($organizationId > 0) {
$rowToOrganizationIdMap[(int) $rowIndex] = $organizationId; $rowToOrganizationIdMap[(int) $rowIndex] = $organizationId;
++$resolvedByRowIdCount;
continue;
}
$title = $this->extractRowFieldContent($row, 'title');
if ('' !== $title) {
$rowToTitleMap[(int) $rowIndex] = $this->normalizeTitle($title);
}
}
if ([] !== $rowToTitleMap) {
$titleToOrganizationIdMap = $this->resolveOrganizationIdsByTitle(array_values(array_unique(array_filter($rowToTitleMap))));
foreach ($rowToTitleMap as $rowIndex => $title) {
if (isset($rowToOrganizationIdMap[$rowIndex])) {
continue;
}
$organizationId = $titleToOrganizationIdMap[$title] ?? 0;
if ($organizationId > 0) {
$rowToOrganizationIdMap[$rowIndex] = $organizationId;
++$resolvedByTitleToIdCount;
}
} }
} }
@@ -81,21 +51,36 @@ class OrganizationListingTemplateDataListener
return; return;
} }
$organizationTagMap = $this->fetchOrganizationTagMap(array_values(array_unique(array_values($rowToOrganizationIdMap)))); $organizationIds = array_values(array_unique(array_values($rowToOrganizationIdMap)));
$organizationLogoUuidMap = $this->fetchOrganizationLogoUuidMap(array_values(array_unique(array_values($rowToOrganizationIdMap)))); $organizationTagMap = $this->fetchOrganizationTagMap($organizationIds);
$organizationTagMapByTitle = $this->fetchOrganizationTagMapByTitle(array_values(array_unique(array_filter($rowToTitleMap)))); $organizationLogoUuidMap = $this->fetchOrganizationLogoUuidMap($organizationIds);
$organizationTagLabelMap = [];
$rowTagIdsList = [];
foreach ($organizationTagMap as $tagData) {
foreach (($tagData['ids'] ?? []) as $index => $tagId) {
$label = trim((string) (($tagData['labels'][$index] ?? '') ?: ''));
if ('' !== $tagId && '' !== $label && !isset($organizationTagLabelMap[(string) $tagId])) {
$organizationTagLabelMap[(string) $tagId] = $label;
}
}
}
foreach ($rowToOrganizationIdMap as $rowIndex => $organizationId) { foreach ($rowToOrganizationIdMap as $rowIndex => $organizationId) {
$tagData = $organizationTagMap[$organizationId] ?? ['labels' => [], 'slugs' => []];
$logoUuid = $organizationLogoUuidMap[$organizationId] ?? '';
if (!isset($tbody[$rowIndex]) || !\is_array($tbody[$rowIndex])) { if (!isset($tbody[$rowIndex]) || !\is_array($tbody[$rowIndex])) {
continue; continue;
} }
$tbody[$rowIndex]['tag_labels']['content'] = implode(', ', $tagData['labels']); $tagData = $organizationTagMap[$organizationId] ?? ['ids' => [], 'labels' => []];
$tbody[$rowIndex]['tag_slugs']['content'] = implode(',', $tagData['slugs']); $logoUuid = $organizationLogoUuidMap[$organizationId] ?? '';
$tbody[$rowIndex]['tags']['content'] = implode(', ', $tagData['labels']); $tagIdsCsv = implode(',', $tagData['ids']);
$tagLabelsCsv = implode(', ', $tagData['labels']);
$tbody[$rowIndex]['tag_ids']['content'] = $tagIdsCsv;
$tbody[$rowIndex]['tag_labels']['content'] = $tagLabelsCsv;
$tbody[$rowIndex]['tags']['content'] = $tagLabelsCsv;
if ('' !== $logoUuid) { if ('' !== $logoUuid) {
$tbody[$rowIndex]['logo_uuid']['content'] = $logoUuid; $tbody[$rowIndex]['logo_uuid']['content'] = $logoUuid;
@@ -103,60 +88,38 @@ class OrganizationListingTemplateDataListener
} }
foreach ($tbody as $rowIndex => $row) { foreach ($tbody as $rowIndex => $row) {
if (!\is_array($row) || isset($rowToOrganizationIdMap[$rowIndex])) {
continue;
}
$title = $this->normalizeTitle($this->extractRowFieldContent($row, 'title'));
if ('' === $title || !isset($organizationTagMapByTitle[$title])) {
continue;
}
$tagData = $organizationTagMapByTitle[$title];
$tbody[$rowIndex]['tag_labels']['content'] = implode(', ', $tagData['labels']);
$tbody[$rowIndex]['tag_slugs']['content'] = implode(',', $tagData['slugs']);
$tbody[$rowIndex]['tags']['content'] = implode(', ', $tagData['labels']);
++$enrichedByTitleTagFallbackCount;
}
$rowsWithoutTagSlugs = 0;
$sampleUnresolvedTitles = [];
foreach ($tbody as $row) {
if (!\is_array($row)) { if (!\is_array($row)) {
$rowTagIdsList[] = '';
continue; continue;
} }
$tagSlugs = $this->extractRowFieldContent($row, 'tag_slugs'); $organizationId = $rowToOrganizationIdMap[(int) $rowIndex] ?? 0;
$rowTagIdsList[] = ($organizationId > 0 && isset($organizationTagMap[$organizationId]))
if ('' !== $tagSlugs) { ? implode(',', $organizationTagMap[$organizationId]['ids'] ?? [])
continue; : '';
} }
++$rowsWithoutTagSlugs; if (null !== $this->logger) {
$rowsWithoutTagIds = 0;
if (\count($sampleUnresolvedTitles) < 10) { foreach ($rowToOrganizationIdMap as $organizationId) {
$title = $this->normalizeTitle($this->extractRowFieldContent($row, 'title')); if (!isset($organizationTagMap[$organizationId]) || [] === ($organizationTagMap[$organizationId]['ids'] ?? [])) {
++$rowsWithoutTagIds;
if ('' !== $title) {
$sampleUnresolvedTitles[] = $title;
}
} }
} }
if (null !== $this->logger && $rowsWithoutTagSlugs > 0) { if ($rowsWithoutTagIds > 0) {
$this->logger->warning('Organization listing tag enrichment left rows without tag slugs.', [ $this->logger->warning('Organization listing enrichment found rows without tag IDs.', [
'template' => (string) $template->getName(), 'template' => (string) $template->getName(),
'totalRows' => \count($tbody), 'totalRows' => \count($tbody),
'resolvedByRowId' => $resolvedByRowIdCount, 'mappedRows' => \count($rowToOrganizationIdMap),
'resolvedByTitleToId' => $resolvedByTitleToIdCount, 'rowsWithoutTagIds' => $rowsWithoutTagIds,
'enrichedByTitleTagFallback' => $enrichedByTitleTagFallbackCount,
'rowsWithoutTagSlugs' => $rowsWithoutTagSlugs,
'sampleUnresolvedTitles' => array_values(array_unique($sampleUnresolvedTitles)),
]); ]);
} }
}
$template->organization_tag_label_map = $organizationTagLabelMap;
$template->organization_row_tag_ids_list = $rowTagIdsList;
$template->tbody = $tbody; $template->tbody = $tbody;
} }
@@ -165,6 +128,10 @@ class OrganizationListingTemplateDataListener
private function extractOrganizationId(array $row): int private function extractOrganizationId(array $row): int
{ {
foreach (['id', 'organization_id', 'org_id'] as $fieldName) { foreach (['id', 'organization_id', 'org_id'] as $fieldName) {
if (isset($row[$fieldName]) && \is_scalar($row[$fieldName]) && ctype_digit((string) $row[$fieldName])) {
return (int) $row[$fieldName];
}
$value = $this->extractRowFieldContent($row, $fieldName); $value = $this->extractRowFieldContent($row, $fieldName);
if ('' !== $value && ctype_digit($value)) { if ('' !== $value && ctype_digit($value)) {
@@ -172,29 +139,23 @@ class OrganizationListingTemplateDataListener
} }
} }
$urlCandidates = [];
foreach ($row as $column) { foreach ($row as $column) {
if (!\is_array($column)) { if (!\is_array($column)) {
continue; continue;
} }
if (isset($column['url']) && \is_scalar($column['url'])) { foreach (['url', 'href'] as $urlField) {
$urlCandidates[] = (string) $column['url']; if (!isset($column[$urlField]) || !\is_scalar($column[$urlField])) {
continue;
} }
if (isset($column['href']) && \is_scalar($column['href'])) { $organizationId = $this->extractIdFromUrl((string) $column[$urlField]);
$urlCandidates[] = (string) $column['href'];
}
}
foreach ($urlCandidates as $url) {
$organizationId = $this->extractIdFromUrl($url);
if ($organizationId > 0) { if ($organizationId > 0) {
return $organizationId; return $organizationId;
} }
} }
}
return 0; return 0;
} }
@@ -202,7 +163,15 @@ class OrganizationListingTemplateDataListener
/** @param array<string, mixed> $row */ /** @param array<string, mixed> $row */
private function extractRowFieldContent(array $row, string $fieldName): string private function extractRowFieldContent(array $row, string $fieldName): string
{ {
if (!isset($row[$fieldName]) || !\is_array($row[$fieldName])) { if (!isset($row[$fieldName])) {
return '';
}
if (\is_scalar($row[$fieldName])) {
return trim((string) $row[$fieldName]);
}
if (!\is_array($row[$fieldName])) {
return ''; return '';
} }
@@ -240,57 +209,8 @@ class OrganizationListingTemplateDataListener
return 0; return 0;
} }
/** @param list<string> $titles
* @return array<string, int>
*/
private function resolveOrganizationIdsByTitle(array $titles): array
{
if ([] === $titles) {
return [];
}
$rows = $this->connection->executeQuery(
'SELECT o.id, o.title FROM tl_organization o WHERE o.title IN (?)',
[$titles],
[ArrayParameterType::STRING],
)->fetchAllAssociative();
$titleToIdsMap = [];
foreach ($rows as $row) {
$organizationId = (int) ($row['id'] ?? 0);
$title = $this->normalizeTitle((string) ($row['title'] ?? ''));
if ($organizationId <= 0 || '' === $title) {
continue;
}
$titleToIdsMap[$title][] = $organizationId;
}
$titleToOrganizationIdMap = [];
foreach ($titleToIdsMap as $title => $organizationIds) {
$organizationIds = array_values(array_unique(array_map('intval', $organizationIds)));
if (1 === \count($organizationIds)) {
$titleToOrganizationIdMap[$title] = $organizationIds[0];
}
}
return $titleToOrganizationIdMap;
}
private function normalizeTitle(string $title): string
{
$title = html_entity_decode($title, ENT_QUOTES | ENT_HTML5, 'UTF-8');
$title = trim(strip_tags($title));
return preg_replace('/\s+/u', ' ', $title) ?? '';
}
/** @param list<int> $organizationIds /** @param list<int> $organizationIds
* @return array<int, array{labels: list<string>, slugs: list<string>}> * @return array<int, array{ids: list<string>, labels: list<string>}>
*/ */
private function fetchOrganizationTagMap(array $organizationIds): array private function fetchOrganizationTagMap(array $organizationIds): array
{ {
@@ -299,35 +219,27 @@ class OrganizationListingTemplateDataListener
} }
$rows = $this->connection->executeQuery( $rows = $this->connection->executeQuery(
'SELECT r.pid AS organization_id, r.tag_id, t.tag AS label FROM tl_tags_rel r INNER JOIN tl_tags t ON t.id = r.tag_id WHERE r.ptable = ? AND r.field = ? AND r.pid IN (?) ORDER BY r.pid ASC, r.tag_id ASC', 'SELECT r.pid AS organization_id, r.tag_id, t.tag AS label
FROM tl_tags_rel r
INNER JOIN tl_tags t ON t.id = r.tag_id
WHERE r.ptable = ? AND r.field = ? AND r.pid IN (?)
ORDER BY r.pid ASC, r.tag_id ASC',
['tl_organization', 'tags', $organizationIds], ['tl_organization', 'tags', $organizationIds],
[ParameterType::STRING, ParameterType::STRING, ArrayParameterType::INTEGER], [ParameterType::STRING, ParameterType::STRING, ArrayParameterType::INTEGER],
)->fetchAllAssociative(); )->fetchAllAssociative();
if ([] === $rows) { if ([] === $rows) {
$rows = $this->connection->executeQuery( $rows = $this->connection->executeQuery(
'SELECT r.pid AS organization_id, r.tag_id, t.tag AS label FROM tl_tags_rel r INNER JOIN tl_tags t ON t.id = r.tag_id WHERE r.ptable = ? AND r.pid IN (?) ORDER BY r.pid ASC, r.tag_id ASC', 'SELECT r.pid AS organization_id, r.tag_id, t.tag AS label
FROM tl_tags_rel r
INNER JOIN tl_tags t ON t.id = r.tag_id
WHERE r.ptable = ? AND r.pid IN (?)
ORDER BY r.pid ASC, r.tag_id ASC',
['tl_organization', $organizationIds], ['tl_organization', $organizationIds],
[ParameterType::STRING, ArrayParameterType::INTEGER], [ParameterType::STRING, ArrayParameterType::INTEGER],
)->fetchAllAssociative(); )->fetchAllAssociative();
} }
if ([] === $rows) {
$rows = $this->connection->executeQuery(
'SELECT r.pid AS organization_id, r.tag_id, t.tag AS label FROM tl_tags_rel r INNER JOIN tl_tags t ON t.id = r.tag_id WHERE r.field = ? AND r.pid IN (?) ORDER BY r.pid ASC, r.tag_id ASC',
['tags', $organizationIds],
[ParameterType::STRING, ArrayParameterType::INTEGER],
)->fetchAllAssociative();
}
if ([] === $rows) {
$rows = $this->connection->executeQuery(
'SELECT r.pid AS organization_id, r.tag_id, t.tag AS label FROM tl_tags_rel r INNER JOIN tl_tags t ON t.id = r.tag_id WHERE r.pid IN (?) ORDER BY r.pid ASC, r.tag_id ASC',
[$organizationIds],
[ArrayParameterType::INTEGER],
)->fetchAllAssociative();
}
$map = []; $map = [];
$seen = []; $seen = [];
@@ -336,92 +248,18 @@ class OrganizationListingTemplateDataListener
$tagId = (int) ($row['tag_id'] ?? 0); $tagId = (int) ($row['tag_id'] ?? 0);
$label = trim((string) ($row['label'] ?? '')); $label = trim((string) ($row['label'] ?? ''));
if ($organizationId <= 0 || $tagId <= 0 || '' === $label) { if ($organizationId <= 0 || $tagId <= 0 || '' === $label || isset($seen[$organizationId][$tagId])) {
continue;
}
if (isset($seen[$organizationId][$tagId])) {
continue; continue;
} }
$seen[$organizationId][$tagId] = true; $seen[$organizationId][$tagId] = true;
$map[$organizationId]['ids'][] = (string) $tagId;
$map[$organizationId]['labels'][] = $label; $map[$organizationId]['labels'][] = $label;
$slug = $this->slugify($label);
if ('' !== $slug) {
$map[$organizationId]['slugs'][] = $slug;
}
} }
foreach ($map as $organizationId => $tagData) { foreach ($map as $organizationId => $tagData) {
$map[$organizationId]['ids'] = array_values(array_unique($tagData['ids'] ?? []));
$map[$organizationId]['labels'] = array_values(array_unique($tagData['labels'] ?? [])); $map[$organizationId]['labels'] = array_values(array_unique($tagData['labels'] ?? []));
$map[$organizationId]['slugs'] = array_values(array_unique($tagData['slugs'] ?? []));
}
return $map;
}
/** @param list<string> $titles
* @return array<string, array{labels: list<string>, slugs: list<string>}>
*/
private function fetchOrganizationTagMapByTitle(array $titles): array
{
if ([] === $titles) {
return [];
}
$rows = $this->connection->executeQuery(
'SELECT o.title, r.tag_id, t.tag AS label FROM tl_organization o INNER JOIN tl_tags_rel r ON r.pid = o.id AND r.ptable = ? INNER JOIN tl_tags t ON t.id = r.tag_id WHERE o.title IN (?) ORDER BY o.title ASC, r.tag_id ASC',
['tl_organization', $titles],
[ParameterType::STRING, ArrayParameterType::STRING],
)->fetchAllAssociative();
if ([] === $rows) {
$rows = $this->connection->executeQuery(
'SELECT o.title, r.tag_id, t.tag AS label FROM tl_organization o INNER JOIN tl_tags_rel r ON r.pid = o.id AND r.field = ? INNER JOIN tl_tags t ON t.id = r.tag_id WHERE o.title IN (?) ORDER BY o.title ASC, r.tag_id ASC',
['tags', $titles],
[ParameterType::STRING, ArrayParameterType::STRING],
)->fetchAllAssociative();
}
if ([] === $rows) {
$rows = $this->connection->executeQuery(
'SELECT o.title, r.tag_id, t.tag AS label FROM tl_organization o INNER JOIN tl_tags_rel r ON r.pid = o.id INNER JOIN tl_tags t ON t.id = r.tag_id WHERE o.title IN (?) ORDER BY o.title ASC, r.tag_id ASC',
[$titles],
[ArrayParameterType::STRING],
)->fetchAllAssociative();
}
$map = [];
$seen = [];
foreach ($rows as $row) {
$title = $this->normalizeTitle((string) ($row['title'] ?? ''));
$tagId = (int) ($row['tag_id'] ?? 0);
$label = trim((string) ($row['label'] ?? ''));
if ('' === $title || $tagId <= 0 || '' === $label) {
continue;
}
if (isset($seen[$title][$tagId])) {
continue;
}
$seen[$title][$tagId] = true;
$map[$title]['labels'][] = $label;
$slug = $this->slugify($label);
if ('' !== $slug) {
$map[$title]['slugs'][] = $slug;
}
}
foreach ($map as $title => $tagData) {
$map[$title]['labels'] = array_values(array_unique($tagData['labels'] ?? []));
$map[$title]['slugs'] = array_values(array_unique($tagData['slugs'] ?? []));
} }
return $map; return $map;
@@ -485,24 +323,4 @@ class OrganizationListingTemplateDataListener
return ''; return '';
} }
private function slugify(string $value): string
{
$value = trim(mb_strtolower($value));
if ('' === $value) {
return '';
}
$value = strtr($value, [
'ä' => 'ae',
'ö' => 'oe',
'ü' => 'ue',
'ß' => 'ss',
]);
$value = preg_replace('/[^a-z0-9]+/u', '-', $value) ?? '';
$value = trim($value, '-');
return $value;
}
} }