Compare commits

...

3 Commits

Author SHA1 Message Date
Jürgen Mummert 5f652530ed Scope view transitions to event list and prevent page shift 2026-04-05 13:55:44 +02:00
Jürgen Mummert 11b927b91f Fix event filter transition jank and restore layout animation 2026-04-05 13:46:00 +02:00
Jürgen Mummert e1a426bde4 Handle skipped view transition promises in event filter 2026-04-05 13:40:57 +02:00
+111 -21
View File
@@ -40,14 +40,62 @@
<style> <style>
.event-filter-target-list { .event-filter-target-list {
view-transition-name: event-filter-list; view-transition-name: event-filter-list;
contain: layout paint;
}
html {
scrollbar-gutter: stable both-edges;
}
body {
overflow-y: scroll;
}
@keyframes event-filter-vt-fade-in {
from {
opacity: 0;
}
to {
opacity: 1;
}
}
@keyframes event-filter-vt-fade-out {
from {
opacity: 1;
}
to {
opacity: 0;
}
} }
@media (prefers-reduced-motion: no-preference) { @media (prefers-reduced-motion: no-preference) {
::view-transition-group(event-filter-list), ::view-transition-group(root),
::view-transition-old(root),
::view-transition-new(root) {
animation: none;
}
::view-transition-group(event-filter-list) {
animation-duration: 240ms;
animation-timing-function: ease;
}
::view-transition-old(event-filter-list), ::view-transition-old(event-filter-list),
::view-transition-new(event-filter-list) { ::view-transition-new(event-filter-list) {
animation-duration: 240ms; animation-duration: 240ms;
animation-timing-function: ease; animation-timing-function: ease;
mix-blend-mode: normal;
}
::view-transition-old(event-filter-list) {
animation-name: event-filter-vt-fade-out;
}
::view-transition-new(event-filter-list) {
animation-name: event-filter-vt-fade-in;
} }
} }
</style> </style>
@@ -132,18 +180,26 @@
const animationMs = 220; const animationMs = 220;
let hideTimers = new WeakMap(); let hideTimers = new WeakMap();
const supportsViewTransitions = typeof document.startViewTransition === 'function'; const supportsViewTransitions = typeof document.startViewTransition === 'function';
const prefersReducedMotion = window.matchMedia('(prefers-reduced-motion: reduce)').matches;
let activeViewTransition = null;
let isViewTransitionMutation = false; let isViewTransitionMutation = false;
let hasAppliedInitialFilter = false;
let currentFilter = { type: 'all', value: '' }; let currentFilter = { type: 'all', value: '' };
let suppressedChangeEvents = 0; let suppressedChangeEvents = 0;
const runWithLayoutTransition = (mutation) => { const runWithLayoutTransition = (mutation) => {
if (!supportsViewTransitions) { if (!supportsViewTransitions || prefersReducedMotion) {
mutation();
return;
}
if (activeViewTransition) {
mutation(); mutation();
return; return;
} }
try { try {
document.startViewTransition(() => { const transition = document.startViewTransition(() => {
isViewTransitionMutation = true; isViewTransitionMutation = true;
try { try {
@@ -152,11 +208,33 @@
isViewTransitionMutation = false; isViewTransitionMutation = false;
} }
}); });
activeViewTransition = transition;
transition.ready.catch(() => {
// Can reject when the transition is skipped.
});
transition.updateCallbackDone.catch(() => {
// Keep skipped/aborted update callbacks from surfacing as uncaught.
});
transition.finished
.catch(() => {
// Browsers can skip overlapping transitions; ignore these rejections.
})
.finally(() => {
if (activeViewTransition === transition) {
activeViewTransition = null;
}
});
} catch (error) { } catch (error) {
mutation(); mutation();
} }
}; };
const shouldMutateVisibilityImmediately = () => supportsViewTransitions && !prefersReducedMotion;
const hasOptionValue = (selectElement, value) => { const hasOptionValue = (selectElement, value) => {
if (!selectElement) { if (!selectElement) {
return false; return false;
@@ -289,17 +367,17 @@
} }
}; };
const showEvent = (eventItem) => { const showEvent = (eventItem, { immediateVisibility = false } = {}) => {
clearHideTimer(eventItem); clearHideTimer(eventItem);
if (eventItem.hidden) { if (immediateVisibility) {
if (supportsViewTransitions && !isViewTransitionMutation) {
runWithLayoutTransition(() => {
eventItem.hidden = false;
});
} else {
eventItem.hidden = false; eventItem.hidden = false;
eventItem.classList.remove('is-filtered-out');
return;
} }
if (eventItem.hidden) {
eventItem.hidden = false;
} }
requestAnimationFrame(() => { requestAnimationFrame(() => {
@@ -307,18 +385,19 @@
}); });
}; };
const hideEvent = (eventItem) => { const hideEvent = (eventItem, { immediateVisibility = false } = {}) => {
clearHideTimer(eventItem); clearHideTimer(eventItem);
if (immediateVisibility) {
eventItem.classList.add('is-filtered-out');
eventItem.hidden = true;
return;
}
eventItem.classList.add('is-filtered-out'); eventItem.classList.add('is-filtered-out');
const timer = window.setTimeout(() => { const timer = window.setTimeout(() => {
if (supportsViewTransitions && !isViewTransitionMutation) {
runWithLayoutTransition(() => {
eventItem.hidden = true; eventItem.hidden = true;
});
} else {
eventItem.hidden = true;
}
hideTimers.delete(eventItem); hideTimers.delete(eventItem);
}, animationMs); }, animationMs);
@@ -411,15 +490,26 @@
currentFilter = filterState; currentFilter = filterState;
setActiveControl(filterState); setActiveControl(filterState);
runWithLayoutTransition(() => { const immediateVisibility = shouldMutateVisibilityImmediately();
const shouldAnimateLayout = immediateVisibility && hasAppliedInitialFilter;
const mutateVisibility = () => {
events.forEach((eventItem) => { events.forEach((eventItem) => {
if (matches(eventItem, filterState)) { if (matches(eventItem, filterState)) {
showEvent(eventItem); showEvent(eventItem, { immediateVisibility });
} else { } else {
hideEvent(eventItem); hideEvent(eventItem, { immediateVisibility });
} }
}); });
}); };
if (shouldAnimateLayout) {
runWithLayoutTransition(mutateVisibility);
} else {
mutateVisibility();
}
hasAppliedInitialFilter = true;
updateStatus(filterState); updateStatus(filterState);
syncState(filterState); syncState(filterState);