Fix event filter transition jank and restore layout animation

contao/templates/frontend/event_filter.html.twig

@@ -38,14 +38,9 @@
 </div>
 
 <style>
-    .event-filter-target-list {
-        view-transition-name: event-filter-list;
-    }
-
     @media (prefers-reduced-motion: no-preference) {
-        ::view-transition-group(event-filter-list),
+        ::view-transition-old(root),
-        ::view-transition-old(event-filter-list),
+        ::view-transition-new(root) {
-        ::view-transition-new(event-filter-list) {
             animation-duration: 240ms;
             animation-timing-function: ease;
         }
@@ -132,18 +127,25 @@
     const animationMs = 220;
     let hideTimers = new WeakMap();
     const supportsViewTransitions = typeof document.startViewTransition === 'function';
+    const prefersReducedMotion = window.matchMedia('(prefers-reduced-motion: reduce)').matches;
+    let activeViewTransition = null;
     let isViewTransitionMutation = false;
     let currentFilter = { type: 'all', value: '' };
     let suppressedChangeEvents = 0;
 
     const runWithLayoutTransition = (mutation) => {
-        if (!supportsViewTransitions) {
+        if (!supportsViewTransitions || prefersReducedMotion) {
+            mutation();
+            return;
+        }
+
+        if (activeViewTransition) {
             mutation();
             return;
         }
 
         try {
-            document.startViewTransition(() => {
+            const transition = document.startViewTransition(() => {
                 isViewTransitionMutation = true;
 
                 try {
@@ -152,11 +154,33 @@
                     isViewTransitionMutation = false;
                 }
             });
+
+            activeViewTransition = transition;
+
+            transition.ready.catch(() => {
+                // Can reject when the transition is skipped.
+            });
+
+            transition.updateCallbackDone.catch(() => {
+                // Keep skipped/aborted update callbacks from surfacing as uncaught.
+            });
+
+            transition.finished
+                .catch(() => {
+                    // Browsers can skip overlapping transitions; ignore these rejections.
+                })
+                .finally(() => {
+                    if (activeViewTransition === transition) {
+                        activeViewTransition = null;
+                    }
+                });
         } catch (error) {
             mutation();
         }
     };
 
+    const shouldMutateVisibilityImmediately = () => supportsViewTransitions && !prefersReducedMotion;
+
     const hasOptionValue = (selectElement, value) => {
         if (!selectElement) {
             return false;
@@ -289,17 +313,17 @@
         }
     };
 
-    const showEvent = (eventItem) => {
+    const showEvent = (eventItem, { immediateVisibility = false } = {}) => {
         clearHideTimer(eventItem);
 
+        if (immediateVisibility) {
+            eventItem.hidden = false;
+            eventItem.classList.remove('is-filtered-out');
+            return;
+        }
+
         if (eventItem.hidden) {
-            if (supportsViewTransitions && !isViewTransitionMutation) {
+            eventItem.hidden = false;
-                runWithLayoutTransition(() => {
-                    eventItem.hidden = false;
-                });
-            } else {
-                eventItem.hidden = false;
-            }
         }
 
         requestAnimationFrame(() => {
@@ -307,18 +331,19 @@
         });
     };
 
-    const hideEvent = (eventItem) => {
+    const hideEvent = (eventItem, { immediateVisibility = false } = {}) => {
         clearHideTimer(eventItem);
+
+        if (immediateVisibility) {
+            eventItem.classList.add('is-filtered-out');
+            eventItem.hidden = true;
+            return;
+        }
+
         eventItem.classList.add('is-filtered-out');
 
         const timer = window.setTimeout(() => {
-            if (supportsViewTransitions && !isViewTransitionMutation) {
+            eventItem.hidden = true;
-                runWithLayoutTransition(() => {
-                    eventItem.hidden = true;
-                });
-            } else {
-                eventItem.hidden = true;
-            }
 
             hideTimers.delete(eventItem);
         }, animationMs);
@@ -411,12 +436,14 @@
         currentFilter = filterState;
         setActiveControl(filterState);
 
+        const immediateVisibility = shouldMutateVisibilityImmediately();
+
         runWithLayoutTransition(() => {
             events.forEach((eventItem) => {
                 if (matches(eventItem, filterState)) {
-                    showEvent(eventItem);
+                    showEvent(eventItem, { immediateVisibility });
                 } else {
-                    hideEvent(eventItem);
+                    hideEvent(eventItem, { immediateVisibility });
                 }
             });
         });